Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add controlPlaneAvailabilityZones and controlPlaneOmitAvailabilityZone variables #157

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

chess-knight
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #154

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

…e variables

Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Copy link
Contributor

@gtema gtema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am barely able to review this: templates over "if"s over templates with "if"s generating patch and no tests for this. It looks fine, but would be great to have possibility to see it in tests

Copy link
Contributor

@michal-gubricky michal-gubricky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chess-knight chess-knight merged commit 960597f into main Aug 6, 2024
2 checks passed
@chess-knight chess-knight deleted the feat/controlPlaneAvailabilityZones branch August 6, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ControlPlaneAvailabilityZones variable for the OpenStack provider
3 participants